Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22794 )
Change subject: IMPALA-13974: Don't check catName if fetching COMMIT_COMPACTION_EVENT or ALLOC_WRITE_ID_EVENT ...................................................................... Patch Set 2: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22794/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/22794/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4214 PS2, Line 4214: // Without filter, there are 4 events: CREATE_TABLE, ALLOC_WRITE_ID_EVENT, ALTER_TABLE, line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e182d32ee2bb8a69c4f71c05eb9e87a5a115f24 Gerrit-Change-Number: 22794 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 07:06:47 +0000 Gerrit-HasComments: Yes