Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22794 )
Change subject: IMPALA-13974: Don't check catName if fetching COMMIT_COMPACTION_EVENT or ALLOC_WRITE_ID_EVENT ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11756/ The failure is due to ALLOC_WRITE_ID_EVENT also have this problem (missing catName). Revealed by the failed FE test: https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/5165/testReport/junit/org.apache.impala.catalog.events/MetastoreEventsProcessorTest/testNotificationEventRequest/ http://gerrit.cloudera.org:8080/#/c/22794/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22794/1//COMMIT_MSG@11 PS1, Line 11: ALLOC_WRITE_ID_EVENT is another kind of transactional table events : generated when a data modification, e.g. INSERT, starts. : > Mention the problematic HMS table (NOTIFICATION_LOG) somewhere in commit me That's the implementation of HMS. I think we'd better not mention it. catName is an optional field of NotificationEvent: https://github.com/apache/hive/blob/be59bd0b445096e431c18bbfa0d682c78ba18b76/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L1515 All HMS events have this field. I'll mention this instead. Hope it's clear. http://gerrit.cloudera.org:8080/#/c/22794/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/22794/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@a1925 PS1, Line 1925: > Can you just comment this so that we are aware what to restore? Done. COMMIT_COMPACTION_EVENT is a table level event. So we don't need to remove this for db level events. -- To view, visit http://gerrit.cloudera.org:8080/22794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e182d32ee2bb8a69c4f71c05eb9e87a5a115f24 Gerrit-Change-Number: 22794 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 07:06:57 +0000 Gerrit-HasComments: Yes
