Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22794
Change subject: IMPALA-13974: Don't check catName if fetching COMMIT_COMPACTION_EVENT ...................................................................... IMPALA-13974: Don't check catName if fetching COMMIT_COMPACTION_EVENT COMMIT_COMPACTION_EVENT is one kind of HMS notification events that are generated when a transactional table finishes a compaction. Due to the bug of HIVE-28912, the catName of COMMIT_COMPACTION_EVENT is always NULL. When checking COMMIT_COMPACTION_EVENT events on a table, we shouldn't set the filter on catName. Otherwise, COMMIT_COMPACTION_EVENT will all be skipped due to this bug. There are two filters we use in fetching HMS events. One is the server side filter we set in NotificationEventRequest. The other one is the client side filter, NotificationFilter, used in filtering events fetched from HMS. This patch removes the check on catName in these filters to avoid missing COMMIT_COMPACTION_EVENT. Tests: - Ran test_hms_event_sync_with_commit_compaction 20 times. Without the fix, it fails in 2-3 runs. Change-Id: I2e182d32ee2bb8a69c4f71c05eb9e87a5a115f24 --- M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/22794/1 -- To view, visit http://gerrit.cloudera.org:8080/22794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e182d32ee2bb8a69c4f71c05eb9e87a5a115f24 Gerrit-Change-Number: 22794 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
