Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22794 )
Change subject: IMPALA-13974: Don't check catName if fetching COMMIT_COMPACTION_EVENT or ALLOC_WRITE_ID_EVENT ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22794/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/22794/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4209 PS2, Line 4209: lterTableEv > nit: This can be a constant. Isn't there one exist in main code? Done http://gerrit.cloudera.org:8080/#/c/22794/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4214 PS2, Line 4214: // Without filter, there are 4 events: CREATE_TABLE, ALLOC_WRITE_ID_EVENT, > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/22794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e182d32ee2bb8a69c4f71c05eb9e87a5a115f24 Gerrit-Change-Number: 22794 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Apr 2025 02:41:31 +0000 Gerrit-HasComments: Yes
