Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22794 )
Change subject: IMPALA-13974: Don't check catName if fetching COMMIT_COMPACTION_EVENT ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Looks OK to me. Lets try run it. http://gerrit.cloudera.org:8080/#/c/22794/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22794/1//COMMIT_MSG@11 PS1, Line 11: : Due to the bug of HIVE-28912, the catName of COMMIT_COMPACTION_EVENT is : always NULL. Mention the problematic HMS table (NOTIFICATION_LOG) somewhere in commit message. http://gerrit.cloudera.org:8080/#/c/22794/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/22794/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@a1925 PS1, Line 1925: Can you just comment this so that we are aware what to restore? // Due to HIVE-28912 we don't check catName in the filter // && MetastoreShim.isDefaultCatalog(e.getCatName()) There are other places where this MetastoreShim.isDefaultCatalog(e.getCatName()) is called. Why they are not commented / removed? -- To view, visit http://gerrit.cloudera.org:8080/22794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e182d32ee2bb8a69c4f71c05eb9e87a5a115f24 Gerrit-Change-Number: 22794 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Apr 2025 16:44:49 +0000 Gerrit-HasComments: Yes
