Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22706 )
Change subject: IMPALA-12427: Documentation for Workload Management ...................................................................... Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@741 PS6, Line 741: </li> > I don't anticipate these particular log messages changing greatly. I modif Ack http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@64 PS7, Line 64: data We need better terminology here and consistently use it throughout this docs. What about "query metrics"? http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@69 PS7, Line 69: currently running queries metrics of currently running queries http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@77 PS7, Line 77: move the queries in this data structure, which have : completed, move the metrics of completed queries from coordinator's memory http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@83 PS7, Line 83: data move is accomplished by metrics write is accomplished through http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@92 PS7, Line 92: data is query metrics are http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@92 PS7, Line 92: data move INSERT query http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@93 PS7, Line 93: in-memory structure Coordinator's memory http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@93 PS7, Line 93: query's : data INSERT http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@125 PS7, Line 125: <colspec colname="1" colwidth = "7*" /> : <colspec colname="1" colwidth = "4*" /> : <colspec colname="1" colwidth = "20*" /> : <colspec colname="1" colwidth = "10*" /> nit: column width can be better. I see some wasted space in one column, and too tight in other column. Consider adding explicit line break for some long strings like Description. http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@858 PS7, Line 858: failed to write completed queries table="sys.impala_query_log" : record_count=3 bytes=3.88 MB gather_time=128.000ms exec_time=1m48s Is this duplicate of similar one below? failed to write completed queries table="sys.impala_query_log" record_count=1 bytes="1.11 KB" gather_time="258.382us" exec_time="1s163ms" query_id="9e4a49a89079233f:c72589eb00000000" -- To view, visit http://gerrit.cloudera.org:8080/22706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c228dfaa3f6060add6e5bd8058551a4d362f460 Gerrit-Change-Number: 22706 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 00:38:13 +0000 Gerrit-HasComments: Yes
