Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22706 )
Change subject: IMPALA-12427: Documentation for Workload Management ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/22706/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22706/8//COMMIT_MSG@9 PS8, Line 9: This change adds documentation for the Workload Management feature. > nit: management is capitalized most other places. Done http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@73 PS8, Line 73: or <codeph>query_log_max_queued</codeph> startup flags, the Workload Management > I'm not sure "maximum queued" provides any additional clarity on "query_log Done http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@75 PS8, Line 75: Iceberg table <codeph>sys.impala_query_log</codeph>. This table is backed by > I'd suggest also discussing graceful shutdown behavior, where it tries to w Done http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@85 PS8, Line 85: <p> > "simply" is generally avoided in technical docs. I'd consider removing this I'm removing the entire section since the first paragraph of this doc states "can be accessed through any SQL client" http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@135 PS8, Line 135: <entry>String</entry> > Do we have a way to automatically generate this table? Unfortunately not easily. We would have to write a fair bit of custom code. I added a comment in above the FIELD_DEFINITIONS struct that changes must be reflected here. http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@612 PS8, Line 612: tailor Workload Management to specific needs. The table below lists the common > It also needs to be enabled on catalogd, so that the `sys` database and tab Done -- To view, visit http://gerrit.cloudera.org:8080/22706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c228dfaa3f6060add6e5bd8058551a4d362f460 Gerrit-Change-Number: 22706 Gerrit-PatchSet: 9 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 12 May 2025 18:10:25 +0000 Gerrit-HasComments: Yes
