Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22706 )
Change subject: IMPALA-12427: Documentation for Workload Management ...................................................................... Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@70 PS6, Line 70: k. : </p> : > First time reader will be confused about this DML mention. Where the DML go Done http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@75 PS6, Line 75: <codeph>query_log_write_interval_s</codeph> startup flag) or maximum queue > This paragraph mainly duplicates the previous one. good catch, the previous paragraph should have been deleted. http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@75 PS6, Line 75: te_interval_s</codeph> startup flag) or maximum queue : setting > Mention the flag name too here. Done http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@131 PS6, Line 131: Column Name</en > Create a separate column for the types? Done http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@146 PS6, Line 146: > How it can help? By increasing or decreasing value? Done http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@222 PS6, Line 222: : </entry> > Clarify what is persisted to disk? Is it the query log, or the data files ( Done http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@282 PS6, Line 282: > > Create a separate column for the types. Done http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@741 PS6, Line 741: </li> > I'm worried documenting log lines will be stale if we change the log messag I don't anticipate these particular log messages changing greatly. I modified the column heading to clarify the logs are only part of the entire log message. Also added details on what action to take (if there is anything that can be done) on error log messages. http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@905 PS6, Line 905: ite completed queries table="sys.impala_query_l > Please add example of maintenance queries for sys.impala_query_log. I assum Done -- To view, visit http://gerrit.cloudera.org:8080/22706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c228dfaa3f6060add6e5bd8058551a4d362f460 Gerrit-Change-Number: 22706 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 19:09:47 +0000 Gerrit-HasComments: Yes
