Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22706 )
Change subject: IMPALA-12427: Documentation for Workload Management ...................................................................... Patch Set 6: (6 comments) I'll do another pass. But here is my early feedbacks. http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@70 PS6, Line 70: The data are batched up into a single <codeph>insert into</codeph> : DML. This DML is executed resulting in the query lifecycle/metrics data to be : inserted into an Apache Iceberg table that is backed by a physical disk store. First time reader will be confused about this DML mention. Where the DML going to? Why first paragraph says in-memory, but later says DML to physical disk store? I think this paragraph can be easier to follow if the table names are mentioned (ie., merge "Tables" section to this "How It Works" section). http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@75 PS6, Line 75: based on the configured write interval or maximum queue : settings Mention the flag name too here. http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@131 PS6, Line 131: <i>Boolean.</i> Create a separate column for the types? http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@146 PS6, Line 146: Helps reduce small file creation How it can help? By increasing or decreasing value? http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@222 PS6, Line 222: completed queries that have not yet : been persisted to disk Clarify what is persisted to disk? Is it the query log, or the data files (parquet, orc) written by the query. http://gerrit.cloudera.org:8080/#/c/22706/6/docs/topics/impala_workload_mgmt.xml@282 PS6, Line 282: <i>String.</i> Create a separate column for the types. -- To view, visit http://gerrit.cloudera.org:8080/22706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c228dfaa3f6060add6e5bd8058551a4d362f460 Gerrit-Change-Number: 22706 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 10 Apr 2025 16:22:18 +0000 Gerrit-HasComments: Yes
