Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22706 )
Change subject: IMPALA-12427: Documentation for Workload Management ...................................................................... Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@64 PS7, Line 64: tele > We need better terminology here and consistently use it throughout this doc I agree we need better terminology and it needs to be consistent. Query metrics is one type of data included in the workload management table. There is also sql state, sql text, plan, tables in query, columns in query, etc. I came up with the word "telemetry" since it reflects that we are collecting different types of information for the purpose of raising visibility into the workloads being handled by Impala. http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@69 PS7, Line 69: > metrics of currently running queries Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@77 PS7, Line 77: : > move the metrics of completed queries from coordinator's memory Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@83 PS7, Line 83: > metrics write is accomplished through Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@92 PS7, Line 92: > query metrics are Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@92 PS7, Line 92: > INSERT query Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@93 PS7, Line 93: p> > Coordinator's memory Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@93 PS7, Line 93: : > INSERT Done http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@125 PS7, Line 125: <colspec colname="1" colwidth = "20*" /> : <colspec colname="1" colwidth = "10*" /> : <thead> : <row> > nit: column width can be better. I see some wasted space in one column, and Modified the column widths and the query_opts sample.. There is no way to add explicit linebreaks without using <p> tags (which adds too much padding before/after. http://gerrit.cloudera.org:8080/#/c/22706/7/docs/topics/impala_workload_mgmt.xml@858 PS7, Line 858: </row> : <row> > Is this duplicate of similar one below? Done -- To view, visit http://gerrit.cloudera.org:8080/22706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c228dfaa3f6060add6e5bd8058551a4d362f460 Gerrit-Change-Number: 22706 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Apr 2025 23:03:39 +0000 Gerrit-HasComments: Yes
