Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate event sequences ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22245/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22245/6//COMMIT_MSG@33 PS6, Line 33: HistogramInterval: 2s312ms, 2s826ms, 3s339ms, 3s853ms, 4s366ms New format looks good but there isn't much value in printing HistogramInterval and HistogramWidth in this case. They can be calculated from Min/Max if needed http://gerrit.cloudera.org:8080/#/c/22245/6/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/22245/6/be/src/util/runtime-profile.cc@2870 PS6, Line 2870: stream << "HistogramInterval: " << interval_summary_line.str() << "\n"; Remove HistogramInterval and HistogramWidth. -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Tue, 08 Apr 2025 13:26:15 +0000 Gerrit-HasComments: Yes
