Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate event sequences ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22245/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22245/5//COMMIT_MSG@19 PS5, Line 19: : The su > Done. I have updated the message now. Done http://gerrit.cloudera.org:8080/#/c/22245/5//COMMIT_MSG@37 PS5, Line 37: - Open Started: 5s885ms, 1s708ms, 3s434ms : - Open Finished: 5s885ms, 1s708ms, 3s435ms : - First Batch Requested: 5s885ms, 1s708ms, 3s435ms > The formats present in PS 3 to 5 were to reduce the number of lines in the Done http://gerrit.cloudera.org:8080/#/c/22245/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22245/8//COMMIT_MSG@20 PS8, Line 20: The summary generated from aggregated instance-level timestamps : (i.e. IMPALA-13304) is used to achieve this within the profile V2, : which covers the possbility of missing events. Is this impact only JSON format or TEXT as well? Please check if these test data needs an update. ./impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt ./impala-profiles/impala_profile_log_tpcds_compute_stats_v2 ./impala-profiles/impala_profile_log_tpcds_compute_stats_v2.expected.json ./impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.pretty.json ./impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 8 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 18:56:17 +0000 Gerrit-HasComments: Yes
