Surya Hebbar has uploaded a new patch set (#5). (
http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate
event sequences
......................................................................
IMPALA-13624: Implement textual representation for aggregate event sequences
This adds support for textual representation of event sequences present
in the aggregated profile(v2).
The patch also tries[WIP] to refactor parts of RuntimeProfileBase
into RuntimeProfile(i.e. info_strings_) as proposed during implementation
of profile V2 in IMPALA-9846.
With the format present in V1 and V2, it becomes difficult to analyze
an event's timestamps across instances.
The event sequences are now displayed in the following comprehensive
format, which would help with an easier view for skew analysis among
other possible use cases.
We achieve this by reusing the generation of aggregated event sequences
within the profile V2, as the extensive considerations of missing events
is already implemented there.
Example,
Verbosity::DEFAULT
json_profile_event_timestamp_limit = 5
Case #1, Number of instances exceeded limit
Node Lifecycle Event Timeline Summary :
- Open Started (1s324ms):
Min: 649.156ms, Avg: 999.670ms, Max: 1s324ms
Histogram: [ 4 0 4 0 4 ], #Inst. Count: 12
- Open Finished (1s325ms):
Min: 649.730ms, Avg: 1s000ms, Max: 1s325ms
Histogram: [ 4 0 4 0 4 ], #Inst. Count: 12
- First Batch Requested (1s325ms):
Min: 989.065ms, Avg: 1s113ms, Max: 1s325ms
Histogram: [ 8 0 0 0 4 ], #Inst. Count: 12
- First Batch Returned (1s361ms):
Min: 1s260ms, Avg: 1s321ms, Max: 1s361ms
Histogram: [ 4 0 0 2 6 ], #Inst. Count: 12
Case #2, Number of instances within the limit
Node Lifecycle Event Timeline:
- Open Started: 727.203ms
- Open Finished: 4s881ms
- First Batch Requested: 4s881ms
With Verbosity::EXTENDED or more, all events and timestamps are printed
with full verbosity as before.
Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0
---
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
2 files changed, 130 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/22245/5
--
To view, visit http://gerrit.cloudera.org:8080/22245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0
Gerrit-Change-Number: 22245
Gerrit-PatchSet: 5
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
