Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate event sequences ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/22245/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22245/5//COMMIT_MSG@19 PS5, Line 19: in the following comprehensive : format Spell it out in commit message: "in histogram format". Please also explain in commit message how the histogram is grouped. http://gerrit.cloudera.org:8080/#/c/22245/5//COMMIT_MSG@37 PS5, Line 37: - Open Finished (1s325ms): : Min: 649.730ms, Avg: 1s000ms, Max: 1s325ms : Histogram: [ 4 0 4 0 4 ], #Inst. Count: 12 The histogram can be more self explanatory if Interval and Width is also printed. https://en.wikipedia.org/wiki/Histogram Maybe something like this instead: - Open Finished (1s325ms): Min: 649.730ms, Avg: 1s000ms, Max: 1s325ms, Count: 12 HistogramCount: 4, 0, 4, 0, 4 HistogramInterval: 649.730ms, 784.116ms, 919.076ms, 1.054s, 1.188s HistogramWidth: 135.054ms http://gerrit.cloudera.org:8080/#/c/22245/5/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/22245/5/be/src/util/runtime-profile.cc@2755 PS5, Line 2755: { Unnecessary scope? http://gerrit.cloudera.org:8080/#/c/22245/5/be/src/util/runtime-profile.cc@2785 PS5, Line 2785: lock_guard<SpinLock> l(event_sequence_lock_); Why is it need to hold lock again here if you have copy event_sequence_map_ to agg_event_sequences? Perhaps, you want to hold this lock for the whole L2755 to L2873? http://gerrit.cloudera.org:8080/#/c/22245/5/be/src/util/runtime-profile.cc@2818 PS5, Line 2818: agg_event_sequence.ToJson(event_sequence_json, &doc); I'm concern about the performance here because it converts into rapidjson first. Please consider creating common struct/data structure that is reusable by this method and AggEventSequence.ToJson()? http://gerrit.cloudera.org:8080/#/c/22245/5/be/src/util/runtime-profile.cc@2832 PS5, Line 2832: stringstream count_summary_line; Reuse this stringstream by moving the declaration before L2816 loop. It will be slightly more memory efficient. -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Mar 2025 19:56:39 +0000 Gerrit-HasComments: Yes
