Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22245 )

Change subject: IMPALA-13624: Implement textual representation for aggregate 
event sequences
......................................................................


Patch Set 4:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22245/4/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

http://gerrit.cloudera.org:8080/#/c/22245/4/be/src/util/runtime-profile.cc@2858
PS4, Line 2858:             stream << prefix << "        " << "|   " << 
symbolic_summary_line.str() << "|\n";
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/22245/4/be/src/util/runtime-profile.cc@2859
PS4, Line 2859:             stream << prefix << "        " << "|   " << 
count_summary_line.str() << "|\n" ;
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0
Gerrit-Change-Number: 22245
Gerrit-PatchSet: 4
Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 13:54:40 +0000
Gerrit-HasComments: Yes

Reply via email to