Mihaly Szjatinya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22474 )

Change subject: IMPALA-11597: Unset impala.lastComputeStatsTime during DROP 
STATS
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22474/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/22474/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2820
PS3, Line 2820:       InProgressTableModification modification =
              :           new InProgressTableModification(catalog_, table);
              :       org.apache.iceberg.Transaction iceTxn =
              :           
IcebergUtil.getIcebergTransaction((FeIcebergTable)table);
              :       I
> This is not addressed yet.
Correct, the behavior for ROW_COUNT and TOTAL_SIZE does not change.

Without much experience with Iceberg tables, my vision is that there is a 
reason why those aren't removed for this table type and that there is some 
parallel mechanism on Iceberg's side to handle those.

As far as TBL_PROP_LAST_COMPUTE_STATS_TIME it is not really a statistic value 
itself so it doesn't necessarily have to be handled in the same way.



--
To view, visit http://gerrit.cloudera.org:8080/22474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9
Gerrit-Change-Number: 22474
Gerrit-PatchSet: 4
Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Mar 2025 14:28:37 +0000
Gerrit-HasComments: Yes

Reply via email to