Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22474 )
Change subject: WIP IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS ...................................................................... Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG@7 PS1, Line 7: WIP IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS : > Ack Done http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG@11 PS1, Line 11: TATS t PARTITION (partition_spec)' : > I haven't found one. We can't do it here since iceberg does not support 'in Ack http://gerrit.cloudera.org:8080/#/c/22474/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2824 PS1, Line 2824: boolean droppedLastCompute = : msTbl.getParameters().remove(HdfsTable.TBL_PROP_LAST_COMPUTE_STATS_TIME) != null; > Seems like it doesn't in this case. There is 'TestEventProcessingWithImpala Ack http://gerrit.cloudera.org:8080/#/c/22474/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/22474/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@266 PS1, Line 266: '','numRows ','2 > Ok, not directly related, but can do. Done -- To view, visit http://gerrit.cloudera.org:8080/22474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Mar 2025 13:02:55 +0000 Gerrit-HasComments: Yes
