Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22474 )
Change subject: IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2742 PS7, Line 2742: if (isIcebergHmsIntegrationEnabled(table.getMetaStoreTable())) { This should be always true because of L2737 http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2743 PS7, Line 2743: modification.registerInflightEvent(); This is already called at L2729. http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2830 PS7, Line 2830: org.apache.hadoop.hive.metastore.api.Table msTbl = table.getMetaStoreTable(); Can we have a Precondition check that the table is not an integrated Iceberg table? http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2890 PS7, Line 2890: EventSequence catalogTimeline Unused parameter http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2891 PS7, Line 2891: modification.addCatalogServiceIdentifiersToTable(); : modification.registerInflightEvent(); I think these are redundant, as these are also called by the callers. http://gerrit.cloudera.org:8080/#/c/22474/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3555 PS7, Line 3555: dropIcebergTableStats IIUC, now when we issue TRUNCATE TABLE on a non-integrated Iceberg table (i.e. an Iceberg table in HadoopTables or HadoopCatalog), the table stats won't be cleared from HMS. For such tables dropTableStats is necessary. -- To view, visit http://gerrit.cloudera.org:8080/22474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Mar 2025 20:41:35 +0000 Gerrit-HasComments: Yes
