Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22474 )
Change subject: IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22474/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2820 PS4, Line 2820: /** : * Drops all table and partition stats from this table in > I think we also need: Ack http://gerrit.cloudera.org:8080/#/c/22474/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3540 PS4, Line 3540: Preconditions.checkState(table.isWriteLockedByCurrentThread()); : Preconditions.checkState(catalog_.getLock().isWriteLockedByCurrentThread()); : Preconditions.checkState(table instanceof FeIcebergTable); : InProgressTableModification modification = : new InProgressTableModification(catalog_, table); : catalog_.getLock().writeLock().unlock(); : modification.addCatalogServiceIdentifiersToTable(); : try { : FeIcebergTable iceTbl = (FeIcebergTable) table; : org.apache.iceberg.Transact > Here in truncateIcebergTable() it would be better to use the same iceTxn an Makes sense. Pls check the newest patch, pls correct it if I'm misusing modification or txn. -- To view, visit http://gerrit.cloudera.org:8080/22474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Mar 2025 18:27:08 +0000 Gerrit-HasComments: Yes
