Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22474 )
Change subject: IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22474/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2820 PS3, Line 2820: boolean droppedLastCompute = : msTbl.getParameters().remove(HdfsTable.TBL_PROP_LAST_COMPUTE_STATS_TIME) != null; : if (droppedLastCompute) { : applyAlterTable(msTbl, false, null, catalogTimeline); : } > Correct, the behavior for ROW_COUNT and TOTAL_SIZE does not change. Yeah, I think it's OK to keep ROW_COUNT and TOTAL_SIZE untouched as they are managed by Iceberg and recreated for each snapshot. http://gerrit.cloudera.org:8080/#/c/22474/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2820 PS4, Line 2820: boolean droppedLastCompute = : msTbl.getParameters().remove(HdfsTable.TBL_PROP_LAS I think we also need: modification.addCatalogServiceIdentifiersToTable(); modification.registerInflightEvent(); http://gerrit.cloudera.org:8080/#/c/22474/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3540 PS4, Line 3540: if (isIcebergHmsIntegrationEnabled(iceTbl.getMetaStoreTable())) { : modification.registerInflightEvent(); : IcebergCatalogOpExecutor.addCatalogVersionToTxn( : iceTxn, catalog_.getCatalogServiceId(), modification.newVersionNumber()); : } : iceTxn.commitTransaction(); : modification.markInflightEventRegistrationComplete(); : modification.validateInProgressModificationComplete(); : } catch (ImpalaException ex) { : modification.cancelInflight Here in truncateIcebergTable() it would be better to use the same iceTxn and modification object to drop table stats of integrated Iceberg tables. I think it should be doable if we create a new method: dropIcebergTableStats(), and dropTableStats() wouldn't do anything for integrated Iceberg tables. And in dropStats() we could also invoke dropIcebergTableStats() for integrated Iceberg tables. -- To view, visit http://gerrit.cloudera.org:8080/22474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Mar 2025 15:20:59 +0000 Gerrit-HasComments: Yes
