Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/21683/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21683/12//COMMIT_MSG@130 PS12, Line 130: ", > I don't think there is a value in appending '(s)' here. Done http://gerrit.cloudera.org:8080/#/c/21683/12//COMMIT_MSG@131 PS12, Line 131: value > nit: values Done http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc@2733 PS12, Line 2733: : void AggregatedRuntimeProfile::PrettyPrintSubclassCounters( : ostream* s, const string& prefix, Verbosity verbosity) const { : ostream& stream = *s; : // Legacy profile did not show aggregated time series counters. : // Showing a time series per instance is too verbose for the default mode, : / > This can be removed. Done http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc@3138 PS12, Line 3138: > This should be the event timeline title, the key of event_sequence_map_? The structure has been kept similar to the traditional profile. But, we can have the event timeline title in the 'profile_name' attribute. Though, this would require another object outside, instead of the current array of objects. http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc@3149 PS12, Line 3149: > I suggest removing this for consistency with the original info string Key. Done -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2024 18:49:33 +0000 Gerrit-HasComments: Yes
