Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 11: I have now added the new backend tests, to verify orderly aggregation of events across instances, and covering the possibility of missing events and complete event sequences. - AggregatedEventSequenceToJson.CompleteEventsTest - AggregatedEventSequenceToJson.MissingEventsTest I have commented out, a new "GetAggregatedEventSequence" method and the associated member declarations within the runtime-profile.cc file. As there is no method within the AggregatedRuntimeProfile to expose AggEventSequence, unlike with RuntimeProfile's "GetEventSequence", I will include it, if it is required. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 11 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2024 13:16:08 +0000 Gerrit-HasComments: No
