Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 13: (1 comment) Thank you for the comments. I will add the additional tests and assertions. http://gerrit.cloudera.org:8080/#/c/21683/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2.expected.pretty.json File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2.expected.pretty.json: http://gerrit.cloudera.org:8080/#/c/21683/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2.expected.pretty.json@2122 PS13, Line 2122: "label": "Prepare Finished", : "ts_stat": { : "min": [1121145, 12230160, 21292017, 34481634, 42591345], : "max": [9319969, 13196927, 21292017, 34481634, 50498895], : "avg": [5902216.75, 12734181.0, 21292017.0, 34481634.0, 45227210.666666667], : "count": [4, 3, 1, 1, 3] : } : }, { : "label": "Open Finished", : "ts_stat": { : "min": [1180328779, 0, 1183114930, 0, 1186253484], : "max": [1181173772, 0, 1183813349, 0, 1187280439], : "avg": [1180580685.75, 0, 1183396700.3333333, 0, 1186635686.2], : "count": [4, 0, 3, 0, 5] : } > Why "count" for "Prepare Finished" does not match/align with "Open Finished As the instances completed the second phase in different spans compared to the first phase, the count distribution is different. This instead helps identify skew in the query timeline. I have already implemented the visualization UI for this form of JSON, which has been posted in a relational chain here. https://gerrit.cloudera.org/#/c/22043/ IMPALA-13474: Support query timeline display for experimental profile The sample output screenshot, I had posted on the dev channel is also from this. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2024 06:58:40 +0000 Gerrit-HasComments: Yes
