Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 12: (5 comments) Thank you for keeping up with the code review so far. There are some that I still like to discuss. http://gerrit.cloudera.org:8080/#/c/21683/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21683/12//COMMIT_MSG@130 PS12, Line 130: (s) I don't think there is a value in appending '(s)' here. http://gerrit.cloudera.org:8080/#/c/21683/12//COMMIT_MSG@131 PS12, Line 131: value nit: values http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc@2733 PS12, Line 2733: /*AggregatedRuntimeProfile::AggEventSequence* AggregatedRuntimeProfile:: : GetAggregatedEventSequence(const std::string& name) const { : lock_guard<SpinLock> l(event_sequence_lock_); : AggEventSequenceMap::const_iterator it = event_sequence_map_.find(name); : if (it == event_sequence_map_.end()) return NULL; : return &(AggEventSequence)it->second; : }*/ This can be removed. http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc@3138 PS12, Line 3138: events This should be the event timeline title, the key of event_sequence_map_? http://gerrit.cloudera.org:8080/#/c/21683/12/be/src/util/runtime-profile.cc@3149 PS12, Line 3149: + "(s)" I suggest removing this for consistency with the original info string Key. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 12 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2024 17:00:52 +0000 Gerrit-HasComments: Yes
