Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 14: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21683/14/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21683/14/be/src/util/runtime-profile-test.cc@1904 PS14, Line 1904: aggregated_profile->ToJsonSubclass(RuntimeProfile::Verbosity::DEFAULT, &plan_node_profile, &doc); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21683/14/be/src/util/runtime-profile-test.cc@1935 PS14, Line 1935: const uint64_t BUCKET_SIZE = FLAGS_aggregate_event_sequence_timestamps_granularity_count; line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 14 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 16:14:20 +0000 Gerrit-HasComments: Yes
