Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 37bb85441f target/riscv: Remaining rvc insn reuse 32 bit translators 9eb32177f0 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 7127800787 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 7b1f42f401 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a17458b518 target/riscv: Convert @cs_2 insns to share translation functions 052d012b95 target/riscv: Remove decode_RV32_64G() c3fcde7f93 target/riscv: Remove gen_system() 082e98ca6c target/riscv: Rename trans_arith to gen_arith e687672603 target/riscv: Remove manual decoding of RV32/64M insn e5b15ba5a8 target/riscv: Remove shift and slt insn manual decoding a85fe50403 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 67a677b8f7 target/riscv: Move gen_arith_imm() decoding into trans_* functions 68428dc7de target/riscv: Remove manual decoding from gen_store() cac91cc71c target/riscv: Remove manual decoding from gen_load() c7341df853 target/riscv: Remove manual decoding from gen_branch() b726b0d129 target/riscv: Remove gen_jalr() 16ccf55b2f target/riscv: Convert quadrant 2 of RVXC insns to decodetree ffe4128236 target/riscv: Convert quadrant 1 of RVXC insns to decodetree d20056d590 target/riscv: Convert quadrant 0 of RVXC insns to decodetree a509f822ba target/riscv: Convert RV priv insns to decodetree bbb45d6628 target/riscv: Convert RV64D insns to decodetree 0dfa35a520 target/riscv: Convert RV32D insns to decodetree 5e4455e54b target/riscv: Convert RV64F insns to decodetree e8461667df target/riscv: Convert RV32F insns to decodetree d198f61b95 target/riscv: Convert RV64A insns to decodetree 5c250c9d43 target/riscv: Convert RV32A insns to decodetree 08eb4cf836 target/riscv: Convert RVXM insns to decodetree 9c29fd0ad6 target/riscv: Convert RVXI csr insns to decodetree 8ba0e0e6ea target/riscv: Convert RVXI fence insns to decodetree 424a350d9b target/riscv: Convert RVXI arithmetic insns to decodetree 7cd95a6fb2 target/riscv: Convert RV64I load/store insns to decodetree 200460b9a9 target/riscv: Convert RV32I load/store insns to decodetree f0ada4c256 target/riscv: Convert RVXI branch insns to decodetree d648923d68 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit d648923d684d (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit f0ada4c2565e (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 200460b9a95f (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 7cd95a6fb2e4 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 424a350d9b21 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 8ba0e0e6eaec (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 9c29fd0ad64f (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 08eb4cf836a1 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5c250c9d43de (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit d198f61b95a4 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit e8461667dfd7 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 5e4455e54bf6 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 0dfa35a52067 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit bbb45d662815 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit a509f822ba82 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit d20056d59070 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit ffe4128236d5 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 16ccf55b2f43 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit b726b0d129e1 (target/riscv: Remove gen_jalr()) 20/34 Checking commit c7341df85382 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit cac91cc71c79 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 68428dc7de6e (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 67a677b8f77f (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit a85fe50403fc (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit e5b15ba5a8a7 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e687672603f5 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 082e98ca6c4f (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit c3fcde7f93dd (target/riscv: Remove gen_system()) 29/34 Checking commit 052d012b957f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit a17458b5189e (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 7b1f42f40175 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 7127800787a7 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 9eb32177f092 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 37bb85441fe0 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
