Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 432ee0f2a6 target/riscv: Remaining rvc insn reuse 32 bit translators 3edd14104b target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 223763f086 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 13d60b86f4 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a0289ca337 target/riscv: Convert @cs_2 insns to share translation functions ef522747fd target/riscv: Remove decode_RV32_64G() 85c176769e target/riscv: Remove gen_system() 7b34c983de target/riscv: Rename trans_arith to gen_arith 3a6d045bea target/riscv: Remove manual decoding of RV32/64M insn 2f6beda13a target/riscv: Remove shift and slt insn manual decoding 9f442e944f target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 743eb3f285 target/riscv: Move gen_arith_imm() decoding into trans_* functions c377ab03d7 target/riscv: Remove manual decoding from gen_store() fe109c44bf target/riscv: Remove manual decoding from gen_load() 9ed52a1acb target/riscv: Remove manual decoding from gen_branch() 0917e89654 target/riscv: Remove gen_jalr() 91ade066d2 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 2c3b66936b target/riscv: Convert quadrant 1 of RVXC insns to decodetree 415e1ab915 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 9af30b4ccc target/riscv: Convert RV priv insns to decodetree 6df8192460 target/riscv: Convert RV64D insns to decodetree 540cd30357 target/riscv: Convert RV32D insns to decodetree 349a03247b target/riscv: Convert RV64F insns to decodetree 3315cb9514 target/riscv: Convert RV32F insns to decodetree 83143afeeb target/riscv: Convert RV64A insns to decodetree 5c2c378e76 target/riscv: Convert RV32A insns to decodetree dffbc3ab8f target/riscv: Convert RVXM insns to decodetree 8ace59a497 target/riscv: Convert RVXI csr insns to decodetree 5cc01544c1 target/riscv: Convert RVXI fence insns to decodetree 080e8e5535 target/riscv: Convert RVXI arithmetic insns to decodetree 8db7ada69f target/riscv: Convert RV64I load/store insns to decodetree 478bc672cd target/riscv: Convert RV32I load/store insns to decodetree cc5a92abae target/riscv: Convert RVXI branch insns to decodetree ae105ec4ed target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit ae105ec4ed93 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit cc5a92abae27 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 478bc672cdfa (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 8db7ada69f10 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 080e8e5535ec (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 5cc01544c1cb (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 8ace59a49753 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit dffbc3ab8f11 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5c2c378e7675 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 83143afeebaa (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 3315cb95145c (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 349a03247b89 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 540cd303579b (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 6df81924601e (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 9af30b4ccc98 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 415e1ab9157d (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 2c3b66936b2e (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 91ade066d2aa (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 0917e8965420 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 9ed52a1acba2 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit fe109c44bf20 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit c377ab03d7ef (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 743eb3f28565 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 9f442e944fe7 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 2f6beda13a13 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 3a6d045bea37 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 7b34c983dec7 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 85c176769e6b (target/riscv: Remove gen_system()) 29/34 Checking commit ef522747fdcd (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit a0289ca33792 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 13d60b86f407 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 223763f0863b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 3edd14104b4c (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 432ee0f2a660 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
