Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 09b35e6bec target/riscv: Remaining rvc insn reuse 32 bit translators 001fe873bc target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 a233183c14 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 4f333d9439 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 0f4ab1f666 target/riscv: Convert @cs_2 insns to share translation functions 277ad6ab96 target/riscv: Remove decode_RV32_64G() 79d8ceccaf target/riscv: Remove gen_system() a1336175d2 target/riscv: Rename trans_arith to gen_arith 31966a003b target/riscv: Remove manual decoding of RV32/64M insn 8b5f580fd4 target/riscv: Remove shift and slt insn manual decoding f16828a0f7 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 515b6c01e9 target/riscv: Move gen_arith_imm() decoding into trans_* functions dfee899202 target/riscv: Remove manual decoding from gen_store() 039f2bcac3 target/riscv: Remove manual decoding from gen_load() 15938cf110 target/riscv: Remove manual decoding from gen_branch() 7d81140be9 target/riscv: Remove gen_jalr() 885dcaa352 target/riscv: Convert quadrant 2 of RVXC insns to decodetree e3ef6243f2 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 101218ffcc target/riscv: Convert quadrant 0 of RVXC insns to decodetree 61980f056c target/riscv: Convert RV priv insns to decodetree bcbf122a87 target/riscv: Convert RV64D insns to decodetree cf608b7d11 target/riscv: Convert RV32D insns to decodetree 3ecdf7cee6 target/riscv: Convert RV64F insns to decodetree 5e2438c3f4 target/riscv: Convert RV32F insns to decodetree 71e4c269db target/riscv: Convert RV64A insns to decodetree b0fb34ef71 target/riscv: Convert RV32A insns to decodetree 177e3a4c9a target/riscv: Convert RVXM insns to decodetree a2ba9f9139 target/riscv: Convert RVXI csr insns to decodetree ddcde05e3c target/riscv: Convert RVXI fence insns to decodetree 8934da9b82 target/riscv: Convert RVXI arithmetic insns to decodetree 0724cbdcba target/riscv: Convert RV64I load/store insns to decodetree 6f697969fa target/riscv: Convert RV32I load/store insns to decodetree 5328de79e7 target/riscv: Convert RVXI branch insns to decodetree e0ffebaa16 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit e0ffebaa16bd (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 5328de79e736 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 6f697969fa15 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 0724cbdcbaa6 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 8934da9b824b (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit ddcde05e3c48 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit a2ba9f913931 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 177e3a4c9a61 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit b0fb34ef7176 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 71e4c269dbda (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 5e2438c3f44a (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 3ecdf7cee665 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit cf608b7d1117 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit bcbf122a87ac (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 61980f056c20 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 101218ffcc3d (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit e3ef6243f218 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 885dcaa352d1 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 7d81140be949 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 15938cf11007 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 039f2bcac3c2 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit dfee89920297 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 515b6c01e924 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit f16828a0f7ed (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 8b5f580fd46b (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 31966a003bde (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit a1336175d24c (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 79d8ceccaf5d (target/riscv: Remove gen_system()) 29/34 Checking commit 277ad6ab9638 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 0f4ab1f666f7 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 4f333d9439c6 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit a233183c1455 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 001fe873bcd5 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 09b35e6becf0 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
