Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 91cc4dfad3 target/riscv: Remaining rvc insn reuse 32 bit translators 79243bdedd target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 ac80713cbf target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 be4a93d1ae target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 0af65c8a81 target/riscv: Convert @cs_2 insns to share translation functions 0f2bcb080e target/riscv: Remove decode_RV32_64G() 48dae4c6c1 target/riscv: Remove gen_system() 81012608ba target/riscv: Rename trans_arith to gen_arith c32b0ddb01 target/riscv: Remove manual decoding of RV32/64M insn 1cbdef86a0 target/riscv: Remove shift and slt insn manual decoding bf1eb05463 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists c44883a45f target/riscv: Move gen_arith_imm() decoding into trans_* functions 729d0c27d8 target/riscv: Remove manual decoding from gen_store() 29268a2e32 target/riscv: Remove manual decoding from gen_load() 42480e9c4e target/riscv: Remove manual decoding from gen_branch() a0e56ae155 target/riscv: Remove gen_jalr() 099e7cc2a9 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 5d417af932 target/riscv: Convert quadrant 1 of RVXC insns to decodetree f717d25ae8 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 7cd07bd1f3 target/riscv: Convert RV priv insns to decodetree 9232eb4b5a target/riscv: Convert RV64D insns to decodetree 161edc2890 target/riscv: Convert RV32D insns to decodetree 04c15ff22d target/riscv: Convert RV64F insns to decodetree b2c620b634 target/riscv: Convert RV32F insns to decodetree aa86b10249 target/riscv: Convert RV64A insns to decodetree 16f0ae6ac1 target/riscv: Convert RV32A insns to decodetree a31688ad60 target/riscv: Convert RVXM insns to decodetree 9445dc0bc2 target/riscv: Convert RVXI csr insns to decodetree e3e07c9150 target/riscv: Convert RVXI fence insns to decodetree e67c611dbe target/riscv: Convert RVXI arithmetic insns to decodetree 1d6f6057a9 target/riscv: Convert RV64I load/store insns to decodetree e8d0a0f018 target/riscv: Convert RV32I load/store insns to decodetree d1a7635515 target/riscv: Convert RVXI branch insns to decodetree b3e857ac85 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit b3e857ac85d4 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit d1a763551523 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit e8d0a0f0186b (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 1d6f6057a90e (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit e67c611dbece (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit e3e07c915094 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 9445dc0bc230 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit a31688ad607d (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 16f0ae6ac198 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit aa86b10249bc (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit b2c620b6342e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 04c15ff22d21 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 161edc2890c8 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 9232eb4b5a32 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 7cd07bd1f3e6 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit f717d25ae89b (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 5d417af9324c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 099e7cc2a965 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit a0e56ae1553e (target/riscv: Remove gen_jalr()) 20/34 Checking commit 42480e9c4ed4 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 29268a2e3292 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 729d0c27d89c (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit c44883a45f26 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit bf1eb054635e (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 1cbdef86a019 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit c32b0ddb018f (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 81012608bac5 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 48dae4c6c1bf (target/riscv: Remove gen_system()) 29/34 Checking commit 0f2bcb080eb1 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 0af65c8a8166 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit be4a93d1aeed (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit ac80713cbf5b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 79243bdedd4b (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 91cc4dfad33a (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
