Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 8567625d24 target/riscv: Remaining rvc insn reuse 32 bit translators 16284d1570 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 7a459f22de target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 178531b141 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 58ad8f384c target/riscv: Convert @cs_2 insns to share translation functions 3a826e8f2c target/riscv: Remove decode_RV32_64G() 6df88e71b4 target/riscv: Remove gen_system() 8200b724b4 target/riscv: Rename trans_arith to gen_arith e640abf75e target/riscv: Remove manual decoding of RV32/64M insn e42677a8e4 target/riscv: Remove shift and slt insn manual decoding e8467f02a2 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists ff020ec93d target/riscv: Move gen_arith_imm() decoding into trans_* functions 1d42c6a385 target/riscv: Remove manual decoding from gen_store() ebdbd7db9b target/riscv: Remove manual decoding from gen_load() f8141eb2ec target/riscv: Remove manual decoding from gen_branch() 8d0f300898 target/riscv: Remove gen_jalr() 8ecb0e9105 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 618692e9c0 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 218512d554 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 036847261f target/riscv: Convert RV priv insns to decodetree d74f1476fe target/riscv: Convert RV64D insns to decodetree 653b965f94 target/riscv: Convert RV32D insns to decodetree 8b9a88d86d target/riscv: Convert RV64F insns to decodetree d8f776f978 target/riscv: Convert RV32F insns to decodetree 1fe180b80f target/riscv: Convert RV64A insns to decodetree 0aa1f5b2a6 target/riscv: Convert RV32A insns to decodetree 921a4104b9 target/riscv: Convert RVXM insns to decodetree 564bdc4ad7 target/riscv: Convert RVXI csr insns to decodetree a93a9825a8 target/riscv: Convert RVXI fence insns to decodetree e45699e605 target/riscv: Convert RVXI arithmetic insns to decodetree 4f7a74fff5 target/riscv: Convert RV64I load/store insns to decodetree b16b342efa target/riscv: Convert RV32I load/store insns to decodetree 03854cfd9d target/riscv: Convert RVXI branch insns to decodetree 23c894a493 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 23c894a4932d (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 03854cfd9d63 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit b16b342efa04 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 4f7a74fff5dc (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit e45699e605de (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit a93a9825a83a (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 564bdc4ad757 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 921a4104b97a (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 0aa1f5b2a658 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 1fe180b80f2b (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit d8f776f978e3 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 8b9a88d86d02 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 653b965f94d3 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit d74f1476fe37 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 036847261f5f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 218512d55491 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 618692e9c08e (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 8ecb0e91056d (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 8d0f300898b6 (target/riscv: Remove gen_jalr()) 20/34 Checking commit f8141eb2ec6c (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit ebdbd7db9b8a (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 1d42c6a38553 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit ff020ec93d95 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit e8467f02a200 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit e42677a8e4aa (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e640abf75e28 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 8200b724b4e3 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 6df88e71b4e0 (target/riscv: Remove gen_system()) 29/34 Checking commit 3a826e8f2cd6 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 58ad8f384c92 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 178531b141dd (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 7a459f22de2e (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 16284d157005 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 8567625d2492 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
