On Tue, Dec 18, 2018 at 10:22:39PM +0100, Paolo Bonzini wrote: > On 18/12/18 20:13, Eduardo Habkost wrote: > > On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote: > >> On 18/12/18 16:57, Eduardo Habkost wrote: > >>> On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote: > >>>> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote: > >>>>> Hi Paolo, Eduardo, > >>>>> > >>>>> On 12/18/18 4:22 PM, Eduardo Habkost wrote: > >>>>>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote: > >>>>>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote: > >>>>>>>> Nobody is looking at those files, downgrade this subsystem as orphan. > >>>>>>>> > >>>>>>>> Remove the qemu-devel@nongnu.org entry because the list is always > >>>>>>>> selected by the 'All patches CC here' section. > >>>>>>>> > >>>>>>>> Suggested-by: Markus Armbruster <arm...@redhat.com> > >>>>>>>> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > >>>>>>>> --- > >>>>>>>> MAINTAINERS | 3 +-- > >>>>>>>> 1 file changed, 1 insertion(+), 2 deletions(-) > >>>>>>>> > >>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS > >>>>>>>> index e50f8c6b97..e6a73820f1 100644 > >>>>>>>> --- a/MAINTAINERS > >>>>>>>> +++ b/MAINTAINERS > >>>>>>>> @@ -1745,8 +1745,7 @@ S: Supported > >>>>>>>> F: scripts/coverity-model.c > >>>>>>>> > >>>>>>>> CPU > >>>>>>>> -L: qemu-devel@nongnu.org > >>>>>>>> -S: Supported > >>>>>>>> +S: Orphan > >>>>>>>> F: qom/cpu.c > >>>>>>>> F: include/qom/cpu.h > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> I don't think that's accurate. Simply there's not much going on. If > >>>>>>> patches are sent, get-maintainers's git fallback will do something > >>>>>>> (probably sending the patch to Eduardo, Igor or me). > >>>>> > >>>>> I followed Markus suggestion from > >>>>> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html: > >>>>> > >>>>> If we take the definition of S: in MAINTAINERS seriously, > >>>>> we need to appoint a maintainer (a person, not a mailing list), > >>>>> or downgrade to S: Orphan. > >>>> > >>>> I agree with Markus and Philippe. Having "S: Supported" but no names > >>>> available is just confusing. So either put a maintainer name in here, or > >>>> downgrade to "Orphan". > >>> > >>> I volunteer to maintain it, but I don't want to be the only > >>> maintainer. Any other volunteer? > >> > >> I can volunteer since I'd take the patches anyway. We can also mark it > >> as Odd Fixes, and also make it a single thing with all of qom/ and > >> include/qom/. > > > > Actually, I consider qom/cpu.c distinct from QOM core, and I was > > planning to move it to hw/cpu, and add hw/cpu/core.c to the same > > section. > > > > Anyway, I guess this means you're also volunteering to be listed > > as QOM maintainer? > > Igor and Daniel, would you co-maintain or review it?
I'm fine being listed as a manitainer for qom/, agree with moving qom/cpu.c to hw/cpu, as I was going to suggest that myself :-) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
