Ok thanks for the advice, I'll adjust for v3. This is (clearly!) my first contribution to Qemu so I'm still learning how you guys operate.
Cheers, -bryan On Mon, Dec 1, 2014 at 2:12 PM, Eric Blake <ebl...@redhat.com> wrote: > On 11/26/2014 01:27 PM, Bryan D. Payne wrote: > > Thanks for the feedback Eric, I've updated the patch. > > > > v2 changes: > > - added QMP command contract to qapi-schema.json > > - corrected some comments > > - rewired QMP command to use schema code > > When sending a v2, it's best to send it as a new top-level thread, > instead of buried in-reply-to an existing thread. Also, for a single > patch, a cover letter is not strictly necessary (the information you > gave here can instead be given after the --- separator of the > one-and-only patch email). Cover letters are mandatory only for > multi-patch series. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > >
