On 11/26/2014 01:27 PM, Bryan D. Payne wrote: > This patch adds a new QMP command that sets up a domain socket. This > socket can then be used for fast read/write access to the guest's > physical memory. The key benefit to this system over existing solutions > is speed. Using this patch, guest memory can be copied out at a rate of > ~200MB/sec, depending on the hardware. Existing solutions only achieve > a small fraction of this speed. > > Signed-off-by: Bryan D. Payne <bdpa...@acm.org>
> + > +## > +# @pmemaccess > +# > +# This command enables access to guest physical memory using > +# a simple protocol over a UNIX domain socket. > +# > +# @path Location to use for the UNIX domain socket > +# > +# Since: 2.3 > +## > +{ 'command': 'pmemaccess', 'data': { 'path': 'str' } } In addition to Fam's review, I have a question - does this code properly use qemu_open() so that I can use 'add-fd' to pass in a pre-opened socket fd into fdset 1, then call pmemaccess with '/dev/fdset/1'? If not, can you please fix it to allow this usage? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature