> > In addition to Fam's review, I have a question - does this code properly > use qemu_open() so that I can use 'add-fd' to pass in a pre-opened > socket fd into fdset 1, then call pmemaccess with '/dev/fdset/1'? If > not, can you please fix it to allow this usage? >
I'm not familiar with this setup. Could you point me to an example of where this is done properly somewhere else in the Qemu code base? Once I figure this out, I'll be able to post the v3 patch. Thanks, -bryan