On 12/04/2014 11:40 AM, Bryan D. Payne wrote: >> >> Off the top of my head, I know the -tpm command line options (related to >> the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c >> for that implementation. > > > So now I do see what you are talking about. But I don't think it applies > to this patch. I'm not using qemu_open in this patch.
But my argument is that you SHOULD be using qemu_open, so that someone can have the option of passing in a pre-opened fd rather than having qemu open it. It matters for cases like libvirt where qemu is running under restricted privileges, and it is easier to have libvirt pass in a pre-opened fd than to figure out how to give qemu the privileges it needs to open the file itself. Even if you don't think your feature will be exposed by libvirt any time soon, it's still worth designing things to be flexible from the beginning. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
