On 2012-03-22 01:05, Paolo Bonzini wrote: > Il 21/03/2012 22:02, Peter Portante ha scritto: >> Hi Folks, >> >> Please forgive me if you find these changes are annoying, as I am trying to >> learn the ropes of patch submission with git ahead of making a real patch. >> >> While working on the code, I found that scripts/checkpatch.pl will flag lines >> that I am changing as not adhereing to the codeing standard due to >> pre-existing coding violations. So I figured I could learn a bit about how to >> submit patches by fixing these files I will be touching before submitting the >> code changes. > > I think slirp is a mess and it's not worth doing this kind of sweeping > change. Just ignore checkpatch output for slirp.
In fact, I could imagine accepting slirp cleanups provided they come in palatable pieces and validate that the binary output is unchanged. It's really a pain changing something in slirp having to use a totally inconsistent style just to keep the code slightly readable. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
