On Thu, Mar 22, 2012 at 12:05 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 21/03/2012 22:02, Peter Portante ha scritto: >> Hi Folks, >> >> Please forgive me if you find these changes are annoying, as I am trying to >> learn the ropes of patch submission with git ahead of making a real patch. >> >> While working on the code, I found that scripts/checkpatch.pl will flag lines >> that I am changing as not adhereing to the codeing standard due to >> pre-existing coding violations. So I figured I could learn a bit about how to >> submit patches by fixing these files I will be touching before submitting the >> code changes. > > I think slirp is a mess and it's not worth doing this kind of sweeping > change. Just ignore checkpatch output for slirp.
Please resend without slirp changes. I suggest including the individual block/raw-posix.c patch you sent in the new series too. > For the others, the changes are pretty small so they could be doable. > If you want to change them then please also add braces around if statements. If you're doing a whitespace patch please include the 3-space indentation issues that checkpatch.pl reports in block/raw-posix.c. > In any case, your patch submission workflow seems to be fine. :P Please use a prefix in your commit messages, for example "raw-posix: whitespace cleanup". This gives each commit a unique, useful message which communicates more than "Yet another whitespace cleanup"-style messages. Stefan
