Il 21/03/2012 22:02, Peter Portante ha scritto: > Hi Folks, > > Please forgive me if you find these changes are annoying, as I am trying to > learn the ropes of patch submission with git ahead of making a real patch. > > While working on the code, I found that scripts/checkpatch.pl will flag lines > that I am changing as not adhereing to the codeing standard due to > pre-existing coding violations. So I figured I could learn a bit about how to > submit patches by fixing these files I will be touching before submitting the > code changes.
I think slirp is a mess and it's not worth doing this kind of sweeping change. Just ignore checkpatch output for slirp. For the others, the changes are pretty small so they could be doable. If you want to change them then please also add braces around if statements. In any case, your patch submission workflow seems to be fine. :P Paolo
