lukasz-antoniak commented on code in PR #340: URL: https://github.com/apache/cassandra-sidecar/pull/340#discussion_r3161663352
########## server/src/main/java/org/apache/cassandra/sidecar/handlers/KeyspaceSchemaHandler.java: ########## Review Comment: `driverUnsupportedSchemaCache.getFullSchema()` will block only if we do not have schema initialised at least once. To prevent "first request" latency, we load the schema as soon as CQL connection is established (see `ConfigurationModule`). My purpose was to change as little code as possible due to this workaround. I had a version to do CQL lookup on non-event loop thread, but then I had to change complete `handleWithMetadata` method. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
