skoppu22 commented on code in PR #340: URL: https://github.com/apache/cassandra-sidecar/pull/340#discussion_r3161542795
########## server/src/main/java/org/apache/cassandra/sidecar/handlers/KeyspaceSchemaHandler.java: ########## Review Comment: This is getting called in the event loop and the below call getFullSchema can invoke cache refresh code which runs under synchronized. Either need to move this to worker pool using executeBlocking. Or other option is to make cache lookup quick by removing refresh from the request call path and use periodic async refresh of the cache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
