skoppu22 commented on code in PR #340:
URL: https://github.com/apache/cassandra-sidecar/pull/340#discussion_r3161323756
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/KeyspaceSchemaHandler.java:
##########
@@ -94,7 +100,9 @@ private void handleWithMetadata(RoutingContext context, Name
keyspace, Metadata
{
if (keyspace == null)
{
- SchemaResponse schemaResponse = new
SchemaResponse(metadata.exportSchemaAsString());
+ String fullSchema = metadata.exportSchemaAsString();
+ fullSchema += driverUnsupportedSchemaCache.getFullSchema();
Review Comment:
- If the first fullschema above doesn't end with newlines and the cache's
schema is non-empty, the two schemas run together without whitespace separation.
- Also, we are doing this kind of concatenation in multiple places in this
PR. Can we have a small utility function ensuring concatenation and whitespace
separation etc handled properly and the same is called everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
