skoppu22 commented on code in PR #340:
URL: https://github.com/apache/cassandra-sidecar/pull/340#discussion_r3162019758
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/KeyspaceSchemaHandler.java:
##########
Review Comment:
If server is down or CQL failed to connect during the first initialization,
subsequent incoming call will run on the event loop blocking other incoming
requests processing. Something like below might work. @frankgh is vertx expert,
might suggest simpler option.
```
executorPools.service().executeBlocking(() ->
driverUnsupportedSchemaCache.getFullSchema())
.onSuccess(unsupportedSchema -> {
String fullSchema = metadata.exportSchemaAsString() +
unsupportedSchema;
context.json(new SchemaResponse(fullSchema));
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
