lukasz-antoniak commented on code in PR #340:
URL: https://github.com/apache/cassandra-sidecar/pull/340#discussion_r3137330503
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/sstableuploads/SSTableUploadHandler.java:
##########
@@ -209,13 +214,17 @@ private Future<SSTableUploadRequestParam>
validateKeyspaceAndTable(String host,
logger.error(message);
return
Future.failedFuture(wrapHttpException(HttpResponseStatus.BAD_REQUEST, message));
}
-
if (MetadataUtils.table(keyspaceMetadata,
request.table()) == null)
{
- String message = String.format("Invalid table name
'%s' supplied for keyspace '%s'",
- request.table(),
request.keyspace());
- logger.error(message);
- return
Future.failedFuture(wrapHttpException(HttpResponseStatus.BAD_REQUEST, message));
+ // check for tables that are not parseable by Java
driver's metadata feature
+ boolean tableExists =
driverUnsupportedSchemaCache.getTableSchema(request.keyspace(),
request.table(), false) != null;
Review Comment:
Do not refresh if table schema is not present in cache (prevent blocking due
to CQL query).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
