On Wed, Feb 26, 2025 at 4:46 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
> Melanie Plageman <melanieplage...@gmail.com> writes: > > I have a patch that is getting thwacked around by the churn in > > stats_import.sql, and it occurred to me that I don't see why all the > > negative tests for pg_restore_relation_stats() need to have all the > > parameters provided. For example, in both of these tests, you are > > testing the relation parameter but including all these other fields. > > It's fine if there is a reason to do that, but otherwise, it makes the > > test file longer and makes the test case less clear IMO. > > +1, let's shorten those queries. The coast is probably pretty > clear now if you want to go do that. On it.
