On Tue, 2025-02-25 at 15:31 -0500, Corey Huinker wrote:
> Documentation:
>
> + The currently-supported relation statistics are
> + <literal>relpages</literal> with a value of type
> + <type>integer</type>, <literal>reltuples</literal> with a
> value of
> + type <type>real</type>, and
> <literal>relallvisible</literal> with a
> + value of type <type>integer</type>.
>
> Could we make this a bullet-list? Same for the required attribute
> stats and optional attribute stats. I think it would be more eye-
> catching and useful to people skimming to recall the name of a
> parameter, which is probably what most people will do after they've
> read it once to get the core concepts.
I couldn't make that look quite right. These functions are mostly for
use by pg_dump, and while documentation is necessary, I don't think we
should go so far as to make it "eye-catching". At least not until
things settle a bit.
> Question:
>
> Do we want to re-compact the oids we consumed in pg_proc.dat?
Done.
> Specifically missing are:
>
> * regclass not found
> * attribute is system column
> * scalars can't have mcelem
> * mcelem / mcelem freqs mismatch (parts 1 and 2)
> * scalars can't have elem_count_histogram
> * cannot set most_common_elems for range type
Done.
And committed.
Regards,
Jeff Davis
