> > I have a patch that is getting thwacked around by the churn in > stats_import.sql, and it occurred to me that I don't see why all the > negative tests for pg_restore_relation_stats() need to have all the > parameters provided. For example, in both of these tests, you are > testing the relation parameter but including all these other fields. > It's fine if there is a reason to do that, but otherwise, it makes the > test file longer and makes the test case less clear IMO. >
It's a known issue, and I intend to do a culling. Things have been changing a lot with the pg_set* functions going away, and some of the tests were covered by set* functions but not restore* functions. I'll give it a pass once the buildfarm goes green again, and then I'm immediately shifting gears to your patchset so that the additional tests you'll require are smooth and minimal.
