On Thu, Jan 23, 2025 at 11:18 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Patch v56-0001 LGTM. >
I have pushed this patch with minor modifications (especially I didn't took Peter Smith's last suggestion to convert some functions to return enum instead of char as the proposed one was consistent with subscription side code and avoided casting in the patch). On of the BF failed https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2025-01-23%2010%3A17%3A03 pg_dump: error: query failed: ERROR: column "publish_gencols_none" does not exist LINE 1: ...elete, false AS pubtruncate, false AS pubviaroot, PUBLISH_GE... ^ pg_dump: detail: Query was: SELECT p.tableoid, p.oid, p.pubname, p.pubowner, p.puballtables, p.pubinsert, p.pubupdate, p.pubdelete, false AS pubtruncate, false AS pubviaroot, PUBLISH_GENCOLS_NONE AS pubgencols_type FROM pg_publication p pg_dumpall: error: pg_dump failed on database "template1", exiting It is probably the case with dump/restore of previous versions. I'll look into this. -- With Regards, Amit Kapila.
