On Tue, Jan 21, 2025 at 7:28 PM vignesh C <vignes...@gmail.com> wrote: > > On Mon, 20 Jan 2025 at 06:14, Peter Smith <smithpb2...@gmail.com> wrote: > > > > Hi Vignesh, > > > > Review comments for patch v53-0001: > > > > > > Maybe I have some fundamental misunderstanding here, but I don't see > > why "this approach cannot be used with psql because older version > > servers may not have these columns". Not having the columns is the > > whole point of using an alias approach in the first place e.g. the > > below table t1 does not have a column called "banana" but it works > > just fine to select an alias using that name... > > This is simpler than maintaining the indexes. I misunderstood your > comment to include displaying the columns for older versions, I did > not want to display a value for the older versions as these columns do > not exist. I have updated the patch based on the alias approach. The > attached patch has the changes for the same. >
Patch v54-0001 LGTM. ====== Kind Regards, Peter Smith. Fujitsu Australia
