On Fri, Jan 24, 2025 at 12:03 AM Shinoda, Noriyoshi (SXD Japan FSI) <noriyoshi.shin...@hpe.com> wrote: > > Hi, hackers. > > Thanks for developing this great feature. > The documentation for the pg_publication catalog shows a 'pubgencols' column, > but the actual column name is the 'pubgencols_type' column. > Also, the order of the columns in the documentation differs from the order of > the columns in the actual pg_publication catalog. > The attached patch changes the column names and order in the documentation. >
Your catalog pg_publication docs fix patch does what it says and looked ok to me. However, in hindsight, I am not sure that the column should have been renamed 'pubgencols_type' in the first place because I cannot find any other catalogs with an underscore in their column names. Maybe 'pubgencolstype' or simply leaving it as 'pubgencols' would have been better? ====== Kind Regards, Peter Smith. Fujitsu Australia
