Attention is currently required from: flichtenheld, ordex, plaisthos.

its_Giaan has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/757?usp=email )

Change subject: event/multi: add event_arg object to make event handling more 
generic
......................................................................


Patch Set 3:

(3 comments)

File src/openvpn/mtcp.c:

http://gerrit.openvpn.net/c/openvpn/+/757/comment/e7aac78d_dff6d54f :
PS2, Line 758: MTCP_SOCKET
> Good catch. […]
Done


File src/openvpn/multi.h:

http://gerrit.openvpn.net/c/openvpn/+/757/comment/c6c7c88f_56fb271e :
PS2, Line 106:     struct event_arg ev_arg;   /* this struct will store a 
pointer to either mi or
> I think new comments should use doxygen formatting. See e.g. "time_t created" 
> below.
Done


File src/openvpn/socket.h:

http://gerrit.openvpn.net/c/openvpn/+/757/comment/7f68de79_70d1df94 :
PS2, Line 181: struct
> I think new comments should use doxygen formatting.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icd7f6a2ad350cdc2312b3e80fa0dbdd7e4311d2e
Gerrit-Change-Number: 757
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: ordex <a...@unstable.cc>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Comment-Date: Wed, 09 Oct 2024 08:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: ordex <a...@unstable.cc>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to